Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter schedule style and functionality #85

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 13, 2025

Summary

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

Test screenshot/video

result.mov

Extra technical notes summary

@a110605 a110605 self-assigned this Jan 13, 2025
@a110605 a110605 changed the title Issue 7347 fix: filter schedule style and functionality Jan 13, 2025
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, LGTM

@@ -25,6 +25,9 @@ export default {

return Array.from(new Set(options));
},
enableFilterButton() {
return this.rows.some((r) => r.sourceSchedule !== undefined);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are fixing this in another PR harvester/dashboard#1263

@a110605 a110605 merged commit 4480dbd into harvester:main Jan 14, 2025
2 checks passed
a110605 added a commit that referenced this pull request Jan 14, 2025
….5/pr-85

fix: filter schedule style and functionality (backport #85)
@a110605 a110605 deleted the issue_7347 branch January 22, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants